Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mlfm-743 feast UI twitter changes #5

Merged
merged 2 commits into from
Mar 17, 2022
Merged

mlfm-743 feast UI twitter changes #5

merged 2 commits into from
Mar 17, 2022

Conversation

mickey-liu
Copy link
Collaborator

@mickey-liu mickey-liu commented Mar 16, 2022 •
edited
Loading

What this PR does / why we need it:

  1. Removes unnecessary files and references to dummy data
  2. Added the clear-icons shell script and included it as a part of yarn build command
  3. Updated the welcome message in the main UI page
  4. Cherry-picked commit a2487b8 which makes some fields optional in UI parser (fix: Update some fields optional in UI parser feast-dev/feast#2380)

Which issue(s) this PR fixes:
https://jira.twitter.biz/browse/MLFM-743

Does this PR introduce a user-facing change?:

None

mickey-liu and others added 2 commits March 16, 2022 15:10
@mickey-liu @adchia
fix: Update some fields optional in UI parser (feast-dev#2380)
a2487b8 
Signed-off-by: Yun Nan Liu <yunnanl@twitter.com>

Co-authored-by: Yun Nan Liu <yunnanl@twitter.com>
Co-authored-by: Danny Chiao <danny@tecton.ai>
twitter specific ui package changes
ce37b41
@mickey-liu mickey-liu merged commit 9390c36 into v0.19.3+twtr Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirayyuce mirayyuce mirayyuce approved these changes

@mavysavydav mavysavydav Awaiting requested review from mavysavydav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mickey-liu @mirayyuce